Skip to content

Dynamically calculate calibration_resuts path#2362

Open
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q wants to merge 1 commit into
remindmodel:developfrom
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q:dev/fix_calibration_results_remind_repos
Open

Dynamically calculate calibration_resuts path#2362
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q wants to merge 1 commit into
remindmodel:developfrom
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q:dev/fix_calibration_results_remind_repos

Conversation

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Copy Markdown
Member

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented Jun 5, 2026

Change calibration_results/.Rprofile_calibration_results to use the current directory the file is located in for the remind_repos option to allow for moving project directories after the calibration_results directory has been set up.
See https://mattermost.pik-potsdam.de/rd3/pl/iiionod59bdquxpj6io7z87bur

@robertpietzcker
Copy link
Copy Markdown
Contributor

robertpietzcker commented Jun 5, 2026

Thanks! sounds great, I just can't comment on the code - I don't know/understand these scripts. so maybe add Lavinia or David as reviewer?

this would lead to an automatic change, or one would need to specify something in the call?

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q force-pushed the dev/fix_calibration_results_remind_repos branch 2 times, most recently from 9af9b88 to fb5d30e Compare June 5, 2026 11:46
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Dynamically calculate calibration_resuts path
eb90cc3 
Change calibration_results/Rprofile_calibration_results to use the
current directory the file is located in for the remind_repos option to
allow for moving project directories after the calibration_results
directory has been set up.
See https://mattermost.pik-potsdam.de/rd3/pl/iiionod59bdquxpj6io7z87bur
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q force-pushed the dev/fix_calibration_results_remind_repos branch from fb5d30e to eb90cc3 Compare June 5, 2026 11:49
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Copy Markdown
Member Author

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented Jun 5, 2026

this would lead to an automatic change, or one would need to specify something in the call?

With this change, when make set-local-calibration is run, REMIND is set up in such a way that the directory ./calibration_results/.Rprofile_calibration_results is in will be added to the remind_repos option at runtime, so it can be copied around without impact.

No change to existing ./calibration_results/ directories, but one can copy

cp ./scripts/utils/set-local-calibration/.Rprofile_calibration_results ./calibration_results/

and then it will work.

@fbenke-pik
Copy link
Copy Markdown
Contributor

fbenke-pik commented Jun 8, 2026

Thanks for the PR, but as this is not my area of expertise, I'll leave this to David and Lavinia.

@fbenke-pik fbenke-pik removed their request for review June 8, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertpietzcker robertpietzcker Awaiting requested review from robertpietzcker

@dklein-pik dklein-pik Awaiting requested review from dklein-pik

@LaviniaBaumstark LaviniaBaumstark Awaiting requested review from LaviniaBaumstark

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q @robertpietzcker @fbenke-pik